[rds-devel] Re: [PATCH 2/2] RDS: Fix a crash on rmmod

[Zach Brown]

Olaf Kirch wrote:
> From: Olaf Kirch <olaf.kirch at oracle.com>
> 
> RDS: Fix a crash on rmmod
> 
> This fixes a crash in rds_ib_remove_one - we really should
> be using list_for_each_entry_safe here.
> 
> Signed-off-by: Olaf Kirch <olaf.kirch at oracle.com>

Agreed.

 Signed-off-by: Zach Brown <zach.brown at oracle.com>

Fwiw, in modern kernels one might prefer using list_first_entry().

	while(!list_empty(list)) {
		item = list_first_entry(list, struct, member);
		list_del(&item->member);
		kfree(item);
	}

- z