[rds-devel] [PATCH RDS/netperf] Add RDS support for netperf-2.4.2

[Zach Brown]

On Jan 8, 2007, at 6:35 AM, Vladimir Sokolovsky wrote:

> Hi,
> The following patch adds the RDS_STREAM test for netperf-2.4.2.

Neat.  What do the netperf maintainers think of the patch?

> +#define OFFICIAL_PF_RDS		32
> +#define OFFICIAL_SOL_RDS	272

This doesn't look right.

RDS doesn't have values reserved in the kernel.  This leads to apps  
having to check at run-time to see what values to use.

Until there are values reserved in the kernel (and even then, don't  
we want to work with older kernels before the reservation?) having  
compiled in values for these constants isn't going to work.

- z