[Ocfs2-users] ocfs2-tools git: broken after commit deb5ade9145f8809f1fde19cf53bdfdf1fb7963e

Dzianis Kahanovich mahatma at bspu.unibel.by
Thu Jul 26 06:37:16 PDT 2012


ocfs2-tools git wrong commit: deb5ade9145f8809f1fde19cf53bdfdf1fb7963e.

After "cleanup unused variable":
-    else
-        tmp = g_list_append(elem, cfs);

o2cb_ctl starts to ignore >1 node. Good commit must be:
    else
-        tmp = g_list_append(elem, cfs);
+        g_list_append(elem, cfs);

Attached patch.

-- 
WBR, Dzianis Kahanovich AKA Denis Kaganovich, http://mahatma.bspu.unibel.by/

-------------- next part --------------
Partial revert of commit deb5ade9145f8809f1fde19cf53bdfdf1fb7963e
Fixed o2cb_ctl ignoring >1 node.

Signed-off-by: Denis Kaganovich (Dzianis Kahanovich) <mahatma at eu.by>

diff -pruN a/o2cb_ctl/jconfig.c b/o2cb_ctl/jconfig.c
--- a/o2cb_ctl/jconfig.c	2012-03-14 21:45:05.000000000 +0300
+++ b/o2cb_ctl/jconfig.c	2012-07-26 16:06:38.000000000 +0300
@@ -1082,6 +1082,8 @@ JConfigStanza *j_config_add_stanza(JConf
                             g_strdup(stanza_name),
                             elem);
     }
+    else
+        g_list_append(elem, cfs);
 
     return(cfs);
 }  /* j_config_add_stanza() */


More information about the Ocfs2-users mailing list