[Ocfs2-users] Re: new ocfs2 packages for Gentoo Linux

[Manish Singh]

On Tue, Jul 05, 2005 at 11:07:34AM -0700, Joel Becker wrote:
> Cc'ing ocfs2-users.
> 
> On Tue, Jul 05, 2005 at 01:39:35PM -0400, Mauricio Zambrano S. wrote:
> >    I ve just made available ocfs2 and ocfs2-tools package for Gentoo 
> > Linux on http://bugs.gentoo.org/show_bug.cgi?id=98024.
> 
> 	We'll have a look in a little bit.  I don't know gentoo
> packaging guidelines, so it might take a while.

I took a quick look. There are a number of issues with the packaging,
which seem to stem from the ebuild stuff being copied from ocfs 1.x
packaging and not being updated to reflect the current state of things.

Kernel module:
* There isn't an --enable-aio configure option anymore. In fact, there
  aren't any optional features controlled by configure at all.
* You seem to be creating a cluster.conf here. There's no way to provide
  a default for this, so what is being put here exactly. Regardless, the
  cluster.conf stuff should be the domain of the tools package, not the
  kernel module.

Tools:
* There is a dependency on pygtk, not gtk+ itself (and certainly not
  such an ancient version as 1.2.8).
* There's a ton of missing dependencies too, like com_err, libuuid,
  libblkid, readline, and python.
* --enable-ocfs2tool is now --enable-ocfs2console
* There's --enable-dynamic-fsck and --enable-dynamic-ctl, which should
  be used instead of non-static.patch.
* The o2cb init script is completely ignored.

I suggest you look at the rpm and deb packaging and try to mimic that as
closely as possible.

-Manish