[Ocfs2-tools-devel] [PATCH 0/7] defragfs.ocfs2: Implement ocfs2 defragmentation tool
Joseph Qi
jiangqi903 at gmail.com
Sun Oct 14 23:08:21 PDT 2018
Umm... I mean we'd better post this patch series with design & implement
intent, not just split each source file. This will let reviewers feel
better.
Framework is the abstraction of the whole implementation, and then
implement each sub-feature one by one.
BTW, we'd better keep each patch compilable.
Thanks,
Joseph
On 18/10/15 11:00, Larry Chen wrote:
> Hi Joseph,
>
> Sorry for the misforming the patch set.
>
> On 10/14/18 11:38 AM, Joseph Qi wrote:
>> Hi Larry,
>> Thanks for your effort to implement this tool.
>> For the patchset, I'd prefer re-organizing them something like:
>> framework
> Does framework means that I should add some description of the code layout in the cover letter?
>
>> specific function implementation
> The functions are included in the source file, so should I add some code comments to key functions?
>
>
>> Makefile
>> manual
>> ...
>>
> I'll reorganize the patch set.
>
> Thanks
> Larry
More information about the Ocfs2-tools-devel
mailing list