[Ocfs2-tools-devel] [PATCH 1/2] fsck: supporting fixing inode alloc group desc

Eric Ren zren at suse.com
Tue Jan 30 22:46:48 PST 2018


>>>>> In the last review:
>>>>> """
>>>>>
>>>>> Hmm, regarding the last parameter of ocfs2_init_group_desc(...,
>>>>> suballoc), is it correct to always
>>>>> set 0 no matter it's global_inode_alloc or inode_alloc?
>>>>> """
>>>>>
>>>>> global_inode_alloc is also sub-alloctor? oh, I think so.
>>>>>
>>>>>
>>>>> Can fsck already fix global bitmap group desc?
>>>>>
>>>> Yes, it could.
>>> Is global_bitmap also a chain allocator? If so, I am curious about how global bitmap groups descs are fixed.
>> Yes, it is.
> So, I guess it will share the similar issue as here. Any good points we
> can learn from there? Let me check a bit there.

Aha, the difference is described below:

"""
   33  * The cluster chain allocator is a special case because its group 
descriptors
   34  * are at regular predictable offsets throughout the volume. fsck 
forces these
   35  * block descriptors into service and removes and block 
descriptors in the
   36  * chain that aren't at these offsets.
"""

Fixing cluster chain allocator is much easier and safe then that of 
inode chain allocator.

Eric



More information about the Ocfs2-tools-devel mailing list