[Ocfs2-tools-devel] [PATCH 1/2] fsck: supporting fixing inode alloc group desc

[Eric Ren]

Hi Jun,

On 02/02/2018 05:19 PM, piaojun wrote:
> Hi Eric,
>
> On 2018/1/31 17:09, Eric Ren wrote:
>> Hi,
>>>> By iterating files, I think you assume all files that cannot travels are valid files.
>> s/cannot/can/
>>
>>>> If there is one that doesn't fits into any bg, it indicates the unusual "bad thing" did
>>>> happen, why not give a warning in that case?
>>> What I concern is that too many files not in first level of chains may
>>> cause too many warnings. And this may seem strange for users.
>> Don't worry. I think it's a normal behavior of fsck tool.
> We iterate files only for the corrupted gds, so the warning is not appropriate.

Sorry for the late reply, little busy these days.

Regarding your last comment, I get your point:  it's too expensive to 
check if a file exists in a certain bg
by iterating all bgs, and it's not the right stage of fsck to check 
files. Do I get understand it right?

Thanks!
Eric