[Ocfs2-tools-devel] [PATCH 3/3] fsck.ocfs2: return error if o2fsck_check_journals fails

[piaojun]

I wonder if more 'fsck_mask |= FSCK_ERROR' need to be added before
'goto unlock;'?

On 2016-9-27 15:57, Joseph Qi wrote:
> If fsck sees unrecoverable errors in journal, return error.
> 
> Signed-off-by: Joseph Qi <joseph.qi at huawei.com>
> ---
>  fsck.ocfs2/fsck.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fsck.ocfs2/fsck.c b/fsck.ocfs2/fsck.c
> index e398b97..db412a7 100644
> --- a/fsck.ocfs2/fsck.c
> +++ b/fsck.ocfs2/fsck.c
> @@ -1001,6 +1001,7 @@ int main(int argc, char **argv)
>  		if (ret) {
>  			printf("fsck saw unrecoverable errors in the journal "
>  				"files and will not continue.\n");
> +			fsck_mask |= FSCK_ERROR;
>  			goto unlock;
>  		}
>  	}
>