[Ocfs2-tools-devel] [ocfs2-tools-devel][PATCH] tunefs.ocfs2: fix the parameter misuse of tunefs_dlm_lock

Joseph Qi joseph.qi at huawei.com
Sat Sep 17 17:19:14 PDT 2016


Thanks, Weiwei.
Reviewed-by: Joseph Qi <joseph.qi at huawei.com>

On 2016/9/14 17:42, Weiwei Wang wrote:
> The third and fourth parameters of tunefs_dlm_lock are misused, so swap the order
> of 'O2DLM_LEVEL_EXMODE' and 'O2DLM_TRYLOCK'passed.
> 
> Signed-off-by: Weiwei Wang <wangww631 at huawei.com>
> Signed-off-by: Jun Piao <piaojun at huawei.com>
> ---
>  tunefs.ocfs2/op_resize_volume.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tunefs.ocfs2/op_resize_volume.c b/tunefs.ocfs2/op_resize_volume.c
> index 84d8628..79f5fd0 100644
> --- a/tunefs.ocfs2/op_resize_volume.c
> +++ b/tunefs.ocfs2/op_resize_volume.c
> @@ -62,8 +62,8 @@ struct resize_specs {
> 
>  static errcode_t online_resize_lock(ocfs2_filesys *fs)
>  {
> -	return tunefs_dlm_lock(fs, lock_name, O2DLM_LEVEL_EXMODE,
> -			       O2DLM_TRYLOCK);
> +	return tunefs_dlm_lock(fs, lock_name, O2DLM_TRYLOCK,
> +			       O2DLM_LEVEL_EXMODE);
>  }
> 
>  static errcode_t online_resize_unlock(ocfs2_filesys *fs)
> 
> 
> .
> 





More information about the Ocfs2-tools-devel mailing list