[Ocfs2-tools-devel] [PATCH] fsck.ocfs2: fix the mistake of clearing valid flag in o2fsck_check_blocks()

[Joseph Qi]

Looks good, thanks.
Reviewed-by: Joseph Qi <joseph.qi at huawei.com>

On 2016/10/11 19:16, piaojun wrote:
> We need use ~OCFS2_VALID_FL rather than !OCFS2_VALID_FL to clear
> 'di->i_flags'.
> 
> Signed-off-by: Jun Piao <piaojun at huawei.com>
> ---
>  fsck.ocfs2/pass1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fsck.ocfs2/pass1.c b/fsck.ocfs2/pass1.c
> index 1ff258a..da11d22 100644
> --- a/fsck.ocfs2/pass1.c
> +++ b/fsck.ocfs2/pass1.c
> @@ -951,7 +951,7 @@ static errcode_t o2fsck_check_blocks(ocfs2_filesys *fs, o2fsck_state *ost,
>  		ret = ocfs2_block_iterate_inode(fs, di,
>  					        OCFS2_BLOCK_FLAG_APPEND,
>  						clear_block, &vb);
> -		di->i_flags &= !OCFS2_VALID_FL;
> +		di->i_flags &= ~OCFS2_VALID_FL;
>  		o2fsck_write_inode(ost, di->i_blkno, di);
>  		/* for a directory, we also need to clear it 
>  		 * from the dir_parent rb-tree. */
>