[Ocfs2-tools-devel] [PATCH] fsck.ocfs2: Free 'ci' in each cycle of for loop in check_journal_walk

piaojun piaojun at huawei.com
Mon Jun 13 23:05:34 PDT 2016


'ci' should be freed in each cycle of for loop in check_journal_walk.

Signed-off-by: Jun Piao <piaojun at huawei.com>
---
 fsck.ocfs2/journal.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/fsck.ocfs2/journal.c b/fsck.ocfs2/journal.c
index bba8499..d0efc8b 100644
--- a/fsck.ocfs2/journal.c
+++ b/fsck.ocfs2/journal.c
@@ -925,10 +925,12 @@ static errcode_t check_journal_walk(o2fsck_state *ost,
 		ret = func(ost, ci, jc);
 		if (ret)
 			break;
-	}
 
-	if (ci)
 		ocfs2_free_cached_inode(fs, ci);
+		ci = NULL;
+	}
+
+	ocfs2_free_cached_inode(fs, ci);
 
 	return ret;
 }
-- 
1.8.4.3




More information about the Ocfs2-tools-devel mailing list