[Ocfs2-tools-devel] [PATCH] Remove deprecated function register_printf_function

Sunil Mushran sunil.mushran at oracle.com
Fri Feb 24 10:02:28 PST 2012


This won't build on RHEL5/SLES10. So we'll need to use compat headers
so that it builds on those envs too.

On 02/24/2012 09:50 AM, Goldwyn Rodrigues wrote:
> op_query.c:326:2: warning: ‘register_printf_function’ is deprecated
> (declared at /usr/include/printf.h:107) [-Wdeprecated-declarations]
>
> Replaced by register_printf_specifier()
>
> Signed-off-by: Goldwyn Rodrigues<rgoldwyn at suse.de>
> ---
>   tunefs.ocfs2/op_query.c |   25 +++++++++++++------------
>   1 files changed, 13 insertions(+), 12 deletions(-)
>
> diff --git a/tunefs.ocfs2/op_query.c b/tunefs.ocfs2/op_query.c
> index b937722..c14e52e 100644
> --- a/tunefs.ocfs2/op_query.c
> +++ b/tunefs.ocfs2/op_query.c
> @@ -222,7 +222,8 @@ static int handle_ro_compat(FILE *stream, const
> struct printf_info *info,
>   	return len;
>   }
>
> -static int handle_arginfo(const struct printf_info *info, size_t n, int *types)
> +static int handle_arginfo(const struct printf_info *info, size_t n, int *types,
> +			  int *size)
>   {
>   	return 0;
>   }
> @@ -323,19 +324,19 @@ static int query_run(struct tunefs_operation
> *op, ocfs2_filesys *fs,
>   		return 1;
>   	}
>
> -	register_printf_function('B', handle_blocksize, handle_arginfo);
> -	register_printf_function('T', handle_clustersize, handle_arginfo);
> -	register_printf_function('N', handle_numslots, handle_arginfo);
> -	register_printf_function('R', handle_rootdir, handle_arginfo);
> -	register_printf_function('Y', handle_sysdir, handle_arginfo);
> -	register_printf_function('P', handle_clustergroup, handle_arginfo);
> +	register_printf_specifier('B', handle_blocksize, handle_arginfo);
> +	register_printf_specifier('T', handle_clustersize, handle_arginfo);
> +	register_printf_specifier('N', handle_numslots, handle_arginfo);
> +	register_printf_specifier('R', handle_rootdir, handle_arginfo);
> +	register_printf_specifier('Y', handle_sysdir, handle_arginfo);
> +	register_printf_specifier('P', handle_clustergroup, handle_arginfo);
>
> -	register_printf_function('V', handle_label, handle_arginfo);
> -	register_printf_function('U', handle_uuid, handle_arginfo);
> +	register_printf_specifier('V', handle_label, handle_arginfo);
> +	register_printf_specifier('U', handle_uuid, handle_arginfo);
>
> -	register_printf_function('M', handle_compat, handle_arginfo);
> -	register_printf_function('H', handle_incompat, handle_arginfo);
> -	register_printf_function('O', handle_ro_compat, handle_arginfo);
> +	register_printf_specifier('M', handle_compat, handle_arginfo);
> +	register_printf_specifier('H', handle_incompat, handle_arginfo);
> +	register_printf_specifier('O', handle_ro_compat, handle_arginfo);
>
>   	query_fs = fs;
>   	fprintf(stdout, fmt);



More information about the Ocfs2-tools-devel mailing list