[Ocfs2-tools-devel] [PATCH] Add crmcommon library for compiling ocfs2_controld

[Sunil Mushran]

On 02/24/2012 09:49 AM, Goldwyn Rodrigues wrote:
> This is to find crm_log_init() from the crmcommon library.
>
> Signed-off-by: Goldwyn Rodrigues<rgoldwyn at suse.de>
> ---
>   ocfs2_controld/Makefile |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/ocfs2_controld/Makefile b/ocfs2_controld/Makefile
> index 52aa493..5272f17 100644
> --- a/ocfs2_controld/Makefile
> +++ b/ocfs2_controld/Makefile
> @@ -67,7 +67,7 @@ DIST_FILES =				\
>   ocfs2_controld.pcmk: $(PCMK_DAEMON_OBJS) $(LIBO2CB_DEPS)
>   	$(LINK) $(GLIB_LIBS) $(LIBO2CB_LIBS) $(COM_ERR_LIBS) \
>   		$(OPENAIS_LIBS) $(COROSYNC_LIBS) \
> -		$(DLMCONTROL_LIBS) -lcrmcluster -lstonithd
> +		$(DLMCONTROL_LIBS) -lcrmcluster -lstonithd -lcrmcommon

Please not naked. Use a variable. CRMCOMMON_LIBS or whatever
is appropriate. Library dependencies change over time. We have
to cleanly handle cases in which the library is not required, etc.