[Ocfs2-tools-devel] [PATCH 3/4] libocfs2: avoid evaluating a garbage value 'sf.ci'

Sunil Mushran sunil.mushran at oracle.com
Mon Sep 19 09:27:33 PDT 2011


Not needed. sf.ci is initialized during ocfs2_open().

On 09/17/2011 08:47 PM, chuanchang.jia at gmail.com wrote:
> libocfs2: avoid evaluating a garbage value 'sf.ci'.
>
> Signed-off-by: Alex Jia<chuanchang.jia at gmail.com>
> ---
>   libocfs2/slot_map.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/libocfs2/slot_map.c b/libocfs2/slot_map.c
> index c33f458..5f54f33 100644
> --- a/libocfs2/slot_map.c
> +++ b/libocfs2/slot_map.c
> @@ -441,7 +441,7 @@ errcode_t ocfs2_format_slot_map(ocfs2_filesys *fs)
>   	ret = ocfs2_lookup_system_inode(fs, SLOT_MAP_SYSTEM_INODE, 0,
>   					&blkno);
>   	if (ret)
> -		goto out;
> +		return ret;
>
>   	ret = ocfs2_read_cached_inode(fs, blkno,&sf.ci);
>   	if (ret)




More information about the Ocfs2-tools-devel mailing list