[Ocfs2-tools-devel] [PATCH 1/4] fsck.ocfs2: avoid evaluating a garbage value 'jis'

Sunil Mushran sunil.mushran at oracle.com
Mon Sep 19 09:24:57 PDT 2011


A better solution is to initialize jis = NULL.

On 09/17/2011 08:47 PM, chuanchang.jia at gmail.com wrote:
> fsck.ocfs2: avoid evaluating a garbage value 'jis'.
>
> Signed-off-by: Alex Jia<chuanchang.jia at gmail.com>
> ---
>   fsck.ocfs2/journal.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fsck.ocfs2/journal.c b/fsck.ocfs2/journal.c
> index 3f87f4f..e724a05 100644
> --- a/fsck.ocfs2/journal.c
> +++ b/fsck.ocfs2/journal.c
> @@ -615,7 +615,7 @@ errcode_t o2fsck_replay_journals(ocfs2_filesys *fs, int *replayed)
>   				&used_blocks);
>   	if (ret) {
>   		com_err(whoami, ret, "while allocating journal block bitmap");
> -		goto out;
> +		return ret;
>   	}
>
>   	ret = ocfs2_malloc_blocks(fs->fs_io, 1,&buf);




More information about the Ocfs2-tools-devel mailing list