[Ocfs2-tools-devel] [PATCH 0/2] ocfs2-tools: avoid dead codes

chuanchang.jia at gmail.com chuanchang.jia at gmail.com
Mon Sep 19 08:27:31 PDT 2011


ocfs2-tools: avoid dead codes.

* debugfs.ocfs2/main.c: 'cmd' has a initial value 'NULL' then take 
'if (opts.cmd_file)' and 'if (!cmd)' true branch, the codes will 
jump into 'bail' section, however, 'cmd' current is 'NULL', so 
fclose(cmd) can't been run forever.

* libocfs2/dir_indexed.c: 'di_buf' has a initial value 'NULL', 
and 'di_buf' hasn't been changed in codes, in 'out' section,
'ocfs2_free(&di_buf)' can't been run forever. 

Signed-off-by: Alex Jia <chuanchang.jia at gmail.com>
---
 debugfs.ocfs2/main.c   |    3 +--
 libocfs2/dir_indexed.c |    3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)



More information about the Ocfs2-tools-devel mailing list