[Ocfs2-tools-devel] [PATCH] Make tunefs.ocfs2 understand all journal options.

[Sunil Mushran]

On 11/22/2011 11:49 AM, Joel Becker wrote:
> 	Nowhere in any of this do you check the filesystem you are
> changing.  While ocfs2_make_journal() will reformat your journal, it
> doesn't handle any of the special case checking that we have in mkfs.
> Things like:
>
> - If your filesystem is larger than can be described by 32bits, you
>    can't go to block32, at least without shrinking your filesystem below
>    the 32bit boundary.
> - If your system can't describe 64bit block numbers correctly, you can't
>    go to block64.
>

I agree with the first check.
The second check cannot be performed in tune. It is done during mount.