[Ocfs2-tools-devel] [PATCH 1/1] ocfs2-tools: add heartbeat=none for hard readonly mount

[Sunil Mushran]

On 05/29/2011 07:07 PM, Tiger Yang wrote:
> On 05/27/2011 01:21 PM, Sunil Mushran wrote:
>> On 05/26/2011 07:29 PM, Tiger Yang wrote:
>>> There is no heartbeat on hard readonly mount, so add option
>>> heartbeat=none for it.
>>
>> Since we've never had this mount op for hard-ro mounts, I would
>> be more inclined to leave it as is rather than add it at this stage.
>>
> In tools 1.6.3 we have this mount option.
>         if (dev_ro || !clustered)
>                 hbstr = OCFS2_HB_NONE;
> and without this option, we can't mount hard ro device.
> say heartbeat=local,  then in ocfs2_fill_super, will return error.
>  /* You should not be able to start a local heartbeat on a readonly device. */
>

Yes, this is a bug in tools HEAD. Let me fix it. I don't like the earlier
code. For e.g., we should be refusing to mount in clustered mode
if device is hard-ro. We have to move this detect to ocfs2_open().