[Ocfs2-tools-devel] [PATCH 0/5] O2info: Adding all the rest of running codes to o2info.

[Tristan Ye]

Sunil Mushran wrote:
> On 06/03/2011 04:33 PM, Joel Becker wrote:
>> On Fri, Jun 03, 2011 at 04:23:31PM -0700, Sunil Mushran wrote:
>>> e.g.,
>>> This is lot more efficient...
>>> numslots=$(o2info volinfo -N [-d DEVICE] FILE)
>>> than...
>>> numslots=$(o2info --volinfo DEVICE | awk '/Node Slots:/ { print $3; }')
>>     Are you proposing that each command have an arbitrary number of
>> switches (-N, -L, etc)?
> 
> Yes.
> 
> # o2cb volinfo --mkfs [-d DEVICE] [FILE]
> will print the output in mkfs format.
> 
> # o2cb volinfo [-d DEVICE] [FILE]
> will print default format
> 
> #o2cb volinfo --fs-features [-d DEVICE] [FILE]
> only features...

Sunil,
	Our original/major intention for having o2info was actually doing 'freefrag'
and 'freeinode', which makes the most sense. you know, --volinfo, --fs-features'
and '--volinfo' was kind of accessaries, which can be equally handled by
debugfs;-), that's why we missed having a good command style(like git style) at
the very beginning.
	Making 'volinfo' as a sub-command, and '--mkfs', '--fs-features' becoming the
options, is going to cause a fair refactoring to existing codes, anyway, I
supported you idea to make a unification in tool's scope, the intention to have
it become easily extensible is also awesome, can you please document the
detailed idea in tool's wiki, then we'll be able to make it happen.

Tristan.
	


> 
> etc.