[Ocfs2-tools-devel] [PATCH 0/5] O2info: Adding all the rest of running codes to o2info.

[Joel Becker]

On Fri, Jun 03, 2011 at 02:21:59PM -0700, Sunil Mushran wrote:
> On 06/03/2011 12:10 AM, Tristan Ye wrote:
> > This patch series keeps tools the same pace with o2info kernel part, and tries
> > to make the o2info a complete utility according to original design doc for the
> > first time, with following codes being added:
> >
> > 	* --freeinode
> >    	* --freefrag
> > 	* --space-usage
> > 	* --filestat
> >
> 
> I think the tool's user-interface is becoming a bit too kludgy.
> 
> My suggestion would be to use the git-style (also used in o2cb tool).
> 
> Here the command will control the type of info and the command options
> will control the output style.
> 
> e.g.,
> # o2info volinfo [--mkfs] DEVICE_OR_FILE
> 
> # o2info fileinfo [--stat] [--frag] [-d DEVICE] FILE
> 
> Something like that. This needs a bit more thought. I think it will be a
> lot more cleaner and more extendible.

	Currently you can specify multiple queries in one shot.  I think
that was one of your original design goals, right?  Your new modes lose
that ability.  I'm not sure that's a bad thing.  I think folks can
handle typing "o2info volinfo /dev/sdb1; o2info fileinfo /dev/sdb1"
instead of "o2info --volinfo --fileinfo /dev/sdb1".

Joel

-- 

"Any man who is under 30, and is not a liberal, has not heart;
 and any man who is over 30, and is not a conservative, has no brains."
         - Sir Winston Churchill 

			http://www.jlbec.org/
			jlbec at evilplan.org