[Ocfs2-tools-devel] [PATCH 1/2] o2hbmonitor: Disk heartbeat monitor

[Sunil Mushran]

On 01/06/2011 06:29 PM, Tristan Ye wrote:
>
>      To make things complete, you may add corresponding stuffs in
> following files:
>
>   CREDITS                                   |    3 +
>   debian/ocfs2-tools.install                |    2 +
>
>

Good point.

>> +	do {
>> +		ent = readdir(dir);
>> +		if (ent&&  ent->d_type == 4&&  strcmp(ent->d_name, ".")&&
>      Will 'ent->d_type == DT_DIR' make things clear?

Another good point.

>> +
>> +	closedir(dir);
>> +
>> +	if (cluster_name)
>> +		return 0;
>      Ok, I'm still tangling on releasing the 'cluster_name' if monitor
> dies by SIGINT or SIGTERM,
> does an explicit signal handler for cleanup really hurts the simplicity?
> it may look an overkill,
> while it does make the logic clear, at least offers us a way to declaim
> resources if any by the end
> of world.

The kernel will do the cleanup. Why do we care?

For the first two, we can always complete that after the initial checkin.