[Ocfs2-tools-devel] [PATCH 1/4] libocfs2: Return error if we find an inline file in extent_iterate_inode.

[Mark Fasheh]

Looks good to me,

Signed-off-by: Mark Fasheh <mfasheh at suse.com>


On Tue, Sep 21, 2010 at 04:55:35PM +0800, Tao Ma wrote:
> In ocfs2_extent_iterate_inode, we should check whether the
> caller gives us an inlined file, if yes, we should return
> error to it.
> 
> The old indexed dir func did call it when it is inlined. So
> we should return error earilier. This bug will be fixed later.
> 
> Signed-off-by: Tao Ma <tao.ma at oracle.com>
> ---
>  libocfs2/extents.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/libocfs2/extents.c b/libocfs2/extents.c
> index 8b5c34d..d72ae66 100644
> --- a/libocfs2/extents.c
> +++ b/libocfs2/extents.c
> @@ -489,6 +489,9 @@ errcode_t ocfs2_extent_iterate_inode(ocfs2_filesys *fs,
>  			      OCFS2_CHAIN_FL))
>  		goto out;
>  
> +	if (inode->i_dyn_features & OCFS2_INLINE_DATA_FL)
> +		goto out;
> +
>  	el = &inode->id2.i_list;
>  	if (el->l_tree_depth) {
>  		ret = ocfs2_malloc0(sizeof(char *) * el->l_tree_depth,
> -- 
> 1.7.1.GIT
--
Mark Fasheh