[Ocfs2-tools-devel] [PATCH 2/2] extras/check_metaecc: use ocfs2_read_blocks_nocache(), v2

Sunil Mushran sunil.mushran at oracle.com
Tue May 25 13:16:23 PDT 2010


Signed-off-by: Sunil Mushran <sunil.mushran at oracle.com>

On 05/25/2010 01:27 AM, Coly Li wrote:
> check_metaecc currently calls ocfs2_read_blocks() to read meta data
> blocks. If the cached block inside memory is corrupted, check_metaecc
> will still report an ECC error even the on-disk data is correct.
>
> This patch makes check_metaecc call ocfs2_read_blocks_nocache(), which
> may avoid the above issue.
>
> Reported-by: Jiaju Zhang<JJZhang at novell.com>
> Signed-off-by: Coly Li<coly.li at suse.de>
> ---
>   extras/check_metaecc.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/extras/check_metaecc.c b/extras/check_metaecc.c
> index ff06068..575f737 100644
> --- a/extras/check_metaecc.c
> +++ b/extras/check_metaecc.c
> @@ -267,7 +267,7 @@ int main(int argc, char *argv[])
>   		goto out_close;
>   	}
>
> -	err = ocfs2_read_blocks(fs, blkno, 1, block);
> +	err = ocfs2_read_blocks_nocache(fs, blkno, 1, block);
>   	if (err) {
>   		com_err(argv[0], err,
>   			"while reading block #%"PRIu64" on \"%s\"\n",
>    




More information about the Ocfs2-tools-devel mailing list