[Ocfs2-tools-devel] [PATCH] extras/check_metaecc: A tool to check metaecc of a metadata block

[Sunil Mushran]

On 05/19/2010 11:40 AM, Coly Li wrote:
>
> On 05/20/2010 02:23 AM, Sunil Mushran Wrote:
>    
>> On 05/19/2010 11:23 AM, Coly Li wrote:
>>      
>>> - if crc32 matched in fast path,
>>>      Block xxxx, CRC32: xxxxx   ECC: xxxxx
>>>      Calculated, CRC32: xxxxx
>>>      Check OK.
>>>
>>> - if ecc matched,
>>>      Block xxxx, CRC32: xxxxx   ECC: xxxxx
>>>      Calculated, CRC32: xxxxx   ECC: xxxxx
>>>      Check OK.
>>>
>>> - if dismatched,
>>>      Block xxxx, CRC32: xxxxx   ECC: xxxxx
>>>      Calculated, CRC32: xxxxx   ECC: xxxxx
>>>      Check Failed.
>>>
>>>        
>> How about...
>>
>>     Block xxxx    CRC32: xxxxx   ECC: xxxxx
>>     Pass          CRC32: xxxxx   ECC: xxxxx
>>
>>     Block xxxx    CRC32: xxxxx   ECC: xxxxx
>>     ** Fail       CRC32: xxxxx   ECC: xxxxx
>>
>> The outputs should be aligned so that it is easy to read. Also, I don't
>> see the value of fastpath.
>>
>>      
> For fast path, there is no ecc calculated. If crc32 matched firstly, what should I display in ECC field ?
>
> How about this ? If the validation passed, just print Pass. Only display CRC32 and ECC when the validation failed. It
> might make sense.
>    

oh... fast path is in validation.

Yes, no point printing the values on Pass.

How about:

    Block xxxx    CRC32: xxxxx   ECC: xxxxx  PASS

    Block xxxx    CRC32: xxxxx   ECC: xxxxx  FAIL
    Calculated    CRC32: xxxxx   ECC: xxxxx