[Ocfs2-tools-devel] [PATCH] extras/check_metaecc: A tool to check metaecc of a metadata block

[Coly Li]

On 05/19/2010 02:33 AM, Joel Becker Wrote:
> On Wed, May 19, 2010 at 01:06:34AM +0800, Coly Li wrote:
>> +	fprintf(stderr, "Signature of block #%"PRIu64" on device %s : \"%s\"\n", blk, dev, name);
> 
> 	Please print the actual checksum and ecc data here.  Copy the
> fprintf from debugfs.ocfs2/dump.c:dump_block_check().  This allows us to
> see the actual values.

Copied, the modified info will be:

- if crc32 matched in fast path,
   Block xxxx, CRC32: xxxxx   ECC: xxxxx
   Calculated, CRC32: xxxxx
   Check OK.

- if ecc matched,
   Block xxxx, CRC32: xxxxx   ECC: xxxxx
   Calculated, CRC32: xxxxx   ECC: xxxxx
   Check OK.

- if dismatched,
   Block xxxx, CRC32: xxxxx   ECC: xxxxx
   Calculated, CRC32: xxxxx   ECC: xxxxx
   Check Failed.

Thanks for the comments.
-- 
Coly Li
SuSE Labs