[Ocfs2-tools-devel] [PATCH] extras/check_metaecc: A tool to check metaecc of a metadata block

Mark Fasheh mfasheh at suse.com
Tue May 18 11:18:26 PDT 2010


On Tue, May 18, 2010 at 10:55:08AM -0700, Sunil Mushran wrote:
> I have added some comments that should be easy to implement.
> 
> But I am wondering whether we should extend this tool a bit and
> make it work without using ocfs2_open(). fake_fs, maybe. Because
> it won't work if superblock has the problem. Other option is to teach
> it to use backup superblocks.

IMHO the best way to solve the "I can't read the fs due to
invalid super block ecc" with an ocfs2_open() flag to skip ecc checking.
Debugfs and o2image in particular would benefit from this as we can't have
them failing due to such an error.

Coly, the rest of the patch looks good to me. I'm thinking we can put this
in once you adress Sunil's comments.
	--Mark

--
Mark Fasheh



More information about the Ocfs2-tools-devel mailing list