[Ocfs2-tools-devel] [PATCH] mkfs.ocfs2: enable xattr support as a default feature

[Sunil Mushran]

Signed-off-by: Sunil Mushran <sunil.mushran at oracle.com>


Mark Fasheh wrote:
> Most other file systems (specifically I looked at ext3 and ext4) enable
> xattr support by default. Our users are always expecting some feature parity
> in this regard. SLES11 has also been shipping with xattr support with few
> problem reports so far. In addition, having it turned on should have minimal
> impact on the file system until they're actually used.
>
> Signed-off-by: Mark Fasheh <mfasheh at suse.com>
> ---
>  libocfs2/feature_string.c  |   12 ++++++++----
>  mkfs.ocfs2/mkfs.ocfs2.8.in |    2 +-
>  2 files changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/libocfs2/feature_string.c b/libocfs2/feature_string.c
> index 79d5712..7021dba 100644
> --- a/libocfs2/feature_string.c
> +++ b/libocfs2/feature_string.c
> @@ -75,7 +75,8 @@ static struct feature_level_translation ocfs2_feature_levels_table[] = {
>  static ocfs2_fs_options feature_level_defaults[] = {
>  	{OCFS2_FEATURE_COMPAT_BACKUP_SB | OCFS2_FEATURE_COMPAT_JBD2_SB,
>  	 OCFS2_FEATURE_INCOMPAT_SPARSE_ALLOC |
> -	 OCFS2_FEATURE_INCOMPAT_INLINE_DATA,
> +	 OCFS2_FEATURE_INCOMPAT_INLINE_DATA |
> +	 OCFS2_FEATURE_INCOMPAT_XATTR,
>  	 OCFS2_FEATURE_RO_COMPAT_UNWRITTEN},  /* OCFS2_FEATURE_LEVEL_DEFAULT */
>  
>  	{OCFS2_FEATURE_COMPAT_BACKUP_SB | OCFS2_FEATURE_COMPAT_JBD2_SB,
> @@ -97,17 +98,20 @@ static ocfs2_fs_options feature_level_defaults[] = {
>  static ocfs2_fs_options mkfstypes_features_defaults[] = {
>  	{OCFS2_FEATURE_COMPAT_BACKUP_SB | OCFS2_FEATURE_COMPAT_JBD2_SB,
>  	 OCFS2_FEATURE_INCOMPAT_SPARSE_ALLOC |
> -	 OCFS2_FEATURE_INCOMPAT_INLINE_DATA,
> +	 OCFS2_FEATURE_INCOMPAT_INLINE_DATA |
> +	 OCFS2_FEATURE_INCOMPAT_XATTR,
>  	 OCFS2_FEATURE_RO_COMPAT_UNWRITTEN},  /* OCFS2_MKFSTYPE_DEFAULT */
>  
>  	{OCFS2_FEATURE_COMPAT_BACKUP_SB | OCFS2_FEATURE_COMPAT_JBD2_SB,
>  	 OCFS2_FEATURE_INCOMPAT_SPARSE_ALLOC |
> -	 OCFS2_FEATURE_INCOMPAT_INLINE_DATA,
> +	 OCFS2_FEATURE_INCOMPAT_INLINE_DATA |
> +	 OCFS2_FEATURE_INCOMPAT_XATTR,
>  	 OCFS2_FEATURE_RO_COMPAT_UNWRITTEN},  /* OCFS2_MKFSTYPE_DATAFILES */
>  
>  	{OCFS2_FEATURE_COMPAT_BACKUP_SB | OCFS2_FEATURE_COMPAT_JBD2_SB,
>  	 OCFS2_FEATURE_INCOMPAT_SPARSE_ALLOC |
> -	 OCFS2_FEATURE_INCOMPAT_INLINE_DATA,
> +	 OCFS2_FEATURE_INCOMPAT_INLINE_DATA |
> +	 OCFS2_FEATURE_INCOMPAT_XATTR,
>  	 OCFS2_FEATURE_RO_COMPAT_UNWRITTEN},  /* OCFS2_MKFSTYPE_MAIL */
>  
>  	{OCFS2_FEATURE_COMPAT_BACKUP_SB | OCFS2_FEATURE_COMPAT_JBD2_SB,
> diff --git a/mkfs.ocfs2/mkfs.ocfs2.8.in b/mkfs.ocfs2/mkfs.ocfs2.8.in
> index 05ed1c6..c7a7888 100644
> --- a/mkfs.ocfs2/mkfs.ocfs2.8.in
> +++ b/mkfs.ocfs2/mkfs.ocfs2.8.in
> @@ -187,7 +187,7 @@ Chooses fewer features but ensures that the file system can be mounted from olde
>  .RS 1.2i
>  .TP
>  \fBdefault\fR
> -The default feature set tries to strike a balance between providing new features and maintaining compatibility with relatively recent versions of \fIOCFS2\fR. It currently enables \fBsparse\fR, \fBunwritten\fR and \fBinline-data\fR. It also enables \fBrefcount\fR and \fBxattr\fR for the \fIvmstore\fR volumes.
> +The default feature set tries to strike a balance between providing new features and maintaining compatibility with relatively recent versions of \fIOCFS2\fR. It currently enables \fBsparse\fR, \fBunwritten\fR \fBinline-data\fR and \fBxattr\fR. It also enables \fBrefcount\fR for the \fIvmstore\fR volumes.
>  .RE
>  .RS 1.2i
>  .TP
>