[Ocfs2-tools-devel] [PATCH 4/7] libocfs2: Add ocfs2_grow_chain_allocator()

[Joel Becker]

On Fri, Mar 05, 2010 at 11:59:54AM -0800, Sunil Mushran wrote:
> +errcode_t ocfs2_grow_chain_allocator(ocfs2_filesys *fs, int type,
> +				     int slot_num, uint32_t num_clusters)
> +{
> +	errcode_t ret = OCFS2_ET_FILE_NOT_FOUND;

	This needs a new error.  If I pass in the global bitmap and get
"file not found" as my error, it sounds like the system dir is broken,
not that I shouldn't have passed in the global bitmap to this function.
Cook up OCFS2_ET_CANNOT_GROW or something.
	The rest of the patches are sob'd.

Joel

-- 

"Maybe the time has drawn the faces I recall.
 But things in this life change very slowly,
 If they ever change at all."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127