[Ocfs2-tools-devel] [PATCH 08/11] Ocfs2-tools: Add main.c to o2info.

[tristan]

Joel Becker wrote:
> On Mon, Mar 01, 2010 at 10:10:24AM +0800, tristan wrote:
>   
>> I guess the solution could be, we provide part of operation with
>> both short-options and long-options, and rest of them only have
>> short-options. that's the way tunefs.ocfs2 was doing:
>>     
>  <snip>
>   
>> Usage: o2info [options] <device or file>
>> o2info -h|--help
>> o2info -V|--version
>> [options] can be followings:
>> |--volinfo
>> --fs-features
>> --no-coherency
>> -U|--space-usage
>> -S|--file-statistics
>> -F|--freefrag <chunksize in KB>
>> -I|--freeinode
>>     
>
> 	I don't like it.  It's arbitrary and confusing.  A user will ask
> "Why does this one have a short option and that one not?"  tunefs does
> it for historical reasons.  That doesn't make it a good idea.
>   

It makes sense.

> 	Operations in o2info should not have short options.  They are
> not 'options', the are 'operations'.
>   

You're right, changes will be in next series.

> Joel
>
>