[Ocfs2-tools-devel] [PATCH 12/25] o2cb: Add ops add-heartbeat, remove-heartbeat and heartbeat-mode

[Joel Becker]

On Mon, Jun 28, 2010 at 11:16:50AM -0700, Sunil Mushran wrote:
> On 06/28/2010 11:03 AM, Joel Becker wrote:
> >	I don't understand why we can't verify the uuid.  "A different
> >system entirely" doesn't change the fact that it is useless to add a
> >heartbeat for a disk the system can't see.
> >	Requiring the full path to a heartbeat device seems unfriendly
> >when we can easily handle non-absolute paths.
> 
> A sysadmin may choose to create the cluster.conf on his desktop
> and populate it on all the nodes. This is one of the requirements.
> --config-file has been added just for that purpose.

	Ok, this is most definitely reasonable.

> While a full path is a bit unfriendly, it is hardly limiting. Most users
> provide full paths to devices anycase. In real life, /dev is rarely a cwd.

	It goes against the expectation of all path arguments to almost
every program out there.  I still think it is very antisocial to violate
those expectations.  It doesn't hurt to support this.  If you really
want to err on the side of uuids, you could even assume that any string
without / is a uuid unless there is a block device of the same name in
the current directory.  That is, if there is a directory or regular file
of the same name, you ignore that and treat it as a uuid.  Only if the
name points to a block device do you read the device to get a uuid.

Joel

-- 

"Practice random acts of kindness and senseless acts of beauty."

 Oh, and don't forget where your towel is.

Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127