[Ocfs2-tools-devel] [PATCH 12/25] o2cb: Add ops add-heartbeat, remove-heartbeat and heartbeat-mode

[Joel Becker]

On Sun, Jun 27, 2010 at 10:58:42AM -0700, Sunil Mushran wrote:
> On 06/23/2010 07:50 PM, Joel Becker wrote:
> > 	What if someone is in /dev and asks to add-heartbeat sda1?
> > Just try opening the name.  Only if you get an error of
> > OCFS2_ET_NAMED_DEVICE_NOT_FOUND or OCFS2_ET_BAD_MAGIC do you check for
> > '/'.  If no '/', try it as a uuid.  Also, when someone passes a uuid,
> > you should be verifying that some device actually has that uuid.
> >    
> 
> We intent to allow people to run this tool on a different system
> entirely. So we cannot verify the uuid. And the / check will be
> documented. As in, if you are specifying a device, ensure you
> provide the full path.

	I don't understand why we can't verify the uuid.  "A different
system entirely" doesn't change the fact that it is useless to add a
heartbeat for a disk the system can't see.
	Requiring the full path to a heartbeat device seems unfriendly
when we can easily handle non-absolute paths.

Joel

-- 

"Copy from one, it's plagiarism; copy from two, it's research."
        - Wilson Mizner

Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127