[Ocfs2-tools-devel] [PATCH 21/25] libocfs2: Add c_flags to struct o2cb_cluster_desc

[Joel Becker]

On Wed, Jun 23, 2010 at 08:29:31PM -0700, Joel Becker wrote:
> On Wed, Jun 23, 2010 at 11:44:31AM -0700, Sunil Mushran wrote:
> > diff --git a/libo2cb/o2cb_abi.h b/libo2cb/o2cb_abi.h
> > index 1edbf74..727b7a8 100644
> > --- a/libo2cb/o2cb_abi.h
> > +++ b/libo2cb/o2cb_abi.h
> > @@ -43,4 +43,9 @@
> >  
> >  #define O2CB_GLOBAL_HEARTBEAT_TAG	"global"
> >  
> > +/*
> > + * Cluster info flags (ocfs2_cluster_info.ci_stackflags)
> > + */
> > +#define OCFS2_CLUSTER_O2CB_GLOBAL_HEARTBEAT	(0x01)
> 
> 	Shouldn't this flag live in ocfs2_fs.h, where ci_stackflags
> would be defined?  I don't see ocfs2_fs.h being updated in this patch,
> either.

	I got it out of order.  I see the update to ocfs2_fs.h in the
previous patch.  However, you should still be using the ocfs2_fs.h flag
instead of redefining it in o2cb_abi.h.

Joel

-- 

Life's Little Instruction Book #267

	"Lie on your back and look at the stars."

Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127