[Ocfs2-tools-devel] [PATCH 20/25] libocfs2: Add a compat feature flag OCFS2_FEATURE_COMPAT_CLUSTERINFO_V2

[Joel Becker]

On Wed, Jun 23, 2010 at 11:44:30AM -0700, Sunil Mushran wrote:
> This flag is set and cleared using tunefs.ocfs2 --fs-features=[no]clusterinfo-v2.

	I don't think you should need this argument.  There are features
we don't consider user settable.  We don't allow --fs-features=userspace
either, really.
	This feature should be set automatically when
update-cluster-stack determines it should set CLUSTER_USERSPACE or
CLUSTER_O2CB, and it should be cleared when those are cleared.

>  static ocfs2_fs_options feature_level_defaults[] = {
> -	{OCFS2_FEATURE_COMPAT_BACKUP_SB | OCFS2_FEATURE_COMPAT_JBD2_SB,
> +	{OCFS2_FEATURE_COMPAT_BACKUP_SB | OCFS2_FEATURE_COMPAT_JBD2_SB |
> +		OCFS2_FEATURE_COMPAT_CLUSTERINFO_V2,

	It doesn't belong in any of the feature-level defaults.  Let the
stack descriptor code write it out.

Joel

-- 

"What do you take me for, an idiot?"  
        - General Charles de Gaulle, when a journalist asked him
          if he was happy.

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127