[Ocfs2-tools-devel] [PATCH 11/25] o2cb: Add ops add-node and remove-node

[Joel Becker]

On Wed, Jun 23, 2010 at 11:44:21AM -0700, Sunil Mushran wrote:
>  #define O2CB_DEFAULT_CONFIG_FILE	"/etc/ocfs2/cluster.conf"
> +#define O2CB_DEFAULT_IP_PORT		7777
> +#define O2CB_MAX_NODES			255

	O2NM_MAX_NODES is already in o2cb/o2cb_nodemanager.h.

> +	clustername = cmd->o_argv[1];
> +	nodename = cmd->o_argv[2];
> +
> +	cluster = o2cb_config_get_cluster_by_name(cmd->o_config, clustername);

	Do you need to check for zero-length arguments, or do the
underlying calls find that out?

Joel

-- 

"Ninety feet between bases is perhaps as close as man has ever come
 to perfection."
	- Red Smith

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127