[Ocfs2-tools-devel] [PATCH 09/25] o2cb: Add a new cluster configuration tool

[Joel Becker]

On Wed, Jun 23, 2010 at 11:44:19AM -0700, Sunil Mushran wrote:
> +	if (!config_file)
> +		config_file = strdup(O2CB_DEFAULT_CONFIG_FILE);

	This is pointless.  config_file is already set to the default,
and the string doesn't need to be duplicated.
	Also, I'd store the filename on the cmd just like you do the
live config.  No need for a static variable.

Joel

-- 

 Joel's Second Law:

	If a code change requires additional user setup, it is wrong.

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127