[Ocfs2-tools-devel] [PATCH 1/1] ocfs2-tools: Add setting custom UUID in tunefs.ocfs2 v2

Tiger Yang tiger.yang at oracle.com
Sat Jun 12 20:37:00 PDT 2010


Sunil Mushran wrote:
> Maybe rename it to translate_uuid(). It could confuse readers
> with libuuid.
> +            "Update the UUID? "))
> Handle errors for uuid_parse().
> +    if (len == 36)
> +        if (uuid_parse(cp....))
> +            goto bail;
> +        goto out;
> +    }
> +
> +    for (i = 0; i<  len; i++, cp++) {
> +        if (!isxdigit(*cp))
> +            goto bail;
> +    }
Sunil, Tao, Tristan,
Thanks for your review and comments. I modify the patch for review again.

Thanks
tiger



More information about the Ocfs2-tools-devel mailing list