[Ocfs2-tools-devel] [PATCH 1/1] ocfs2-tools: Add setting custom UUID in tunefs.ocfs2

[Joel Becker]

On Thu, Jun 10, 2010 at 10:17:44PM -0400, Tiger Yang wrote:
> On 06/10/2010 05:31 PM, Joel Becker wrote:
> >
> >>Oh... I was wondering about that. How about...
> >>
> >>+	.opt_help	= "-U|--uuid-reset=[new-uuid]",
> >	Works for me.
> >
> >Joel
> I think we should put the "=" into the bracket. Because that means
> we support --uuid-reset or --uuid-reset=new-uuid two types
> behaviours. And for short form -U, we support -U or -Unew-uuid (no
> equal mark) two types behaviours.

	You're right about the '='.  I don't think you need to specify
the argument to the short form, though.  Knowledgable folks will know
about it, and naiive folks can use the long form.  It's just more
readable, I think.

+	.opt_help	= "-U|--uuid-reset[=new-uuid]",

Joel

-- 

"I inject pure kryptonite into my brain.
 It improves my kung fu, and it eases the pain."


Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127