[Ocfs2-tools-devel] [PATCH 13/20] tunefs.ocfs2: Add enable discontig-bg operations.

Joel Becker Joel.Becker at oracle.com
Thu Jun 10 14:25:32 PDT 2010


On Mon, May 17, 2010 at 04:47:00PM +0800, Tao Ma wrote:
> This patch just adds the support for enable discontig-bg
> in tunefs.ocfs2 so that we can test it easily.
> 
> XXX:
> Do we need to change the bg_size for all the suballocator
> group so that it is consistent when new group is allocated?

	No, we want enabling to leave them as-is.  That gives us some
nice, fast enabling of the feature.  The is_discontig() check works
great against bg_size > offsetof(bg_list).
	Btw, in the kernel ocfs2_bg_discontig_fix_result() checks
l_next_free_rec without checking bg_size.  Can you change it to use the
bg_is_discontig() check?

Joel

-- 

"Drake!  We're LEAVING!"

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127



More information about the Ocfs2-tools-devel mailing list