[Ocfs2-tools-devel] [PATCH 1/1] ocfs2-tools: Add setting custom UUID in tunefs.ocfs2

[Sunil Mushran]

On 06/10/2010 12:45 PM, Joel Becker wrote:
> On Thu, Jun 10, 2010 at 09:57:27AM -0700, Sunil Mushran wrote:
>    
>> We have been moving away from the traditional uuid format.
>> What do others think? Should we support both inputs? I am
>> inclined to support only the first input as that is what -Q "%U"
>> "stats" in debugfs.ocfs2, etc., returns.
>>      
> 	I've actually been wondering if we should be moving towards the
> libuuid format.  Other places in the system, like udev and blkid, report
> that format.  Isn't it confusing for others?
>
>    

We moved to the format because the domain name, etc. is without
the dashes. It is easier to write scripts.

>>>   static struct tunefs_option reset_uuid_option = {
>>>   	.opt_option	= {
>>> -		.name	= "uuid-reset",
>>> -		.val	= 'U',
>>> +		.name		= "uuid-reset",
>>> +		.val		= 'U',
>>> +		.has_arg	= 2,
>>>   	},
>>> -	.opt_help	= "-U|--uuid-reset",
>>> +	.opt_help	= "-U[new-uuid]|--uuid-reset[=new-uuid]",
>>> +	.opt_handle	=&generic_handle_arg,
>>>   	.opt_op		=&reset_uuid_op,
>>>        
>> +	.opt_help	= "-U|--uuid-reset [new-uuid]",
>>      
> 	No can do.  Optional arguments can't be separated by a space.
>    

Oh... I was wondering about that. How about...

+	.opt_help	= "-U|--uuid-reset=[new-uuid]",