[Ocfs2-tools-devel] [PATCH 2/3] fsck.ocfs2: Add extent list check for discontig bg.

[Joel Becker]

On Thu, Jul 22, 2010 at 10:49:37AM +0800, Tao Ma wrote:
> On 07/22/2010 10:28 AM, Joel Becker wrote:
> >	Shouldn't we be checking the last block of the extent, not the
> >first one?
> I am just worried about the case of e_blkno = 0 while the end may be
> valid. but you are also right, so we need to check both e_blkno and
> the last block of the extent.

	Yeah, e_blkno must be > SUPER_BLOCK_BLKNO.

> >		} else if ((total_clusters + rec->e_leaf_clusters)>  cpg) {
> >			if (total_clusters == cpg) {
> >				Ask to truncate l_next_free_rec at i.
> >			} else {
> >				Ask to truncate rec->e_leaf_clusters at
> >				cpg -. total_clusters.  Or perhaps drop
> >				the group if we don't think that is safe
> >				to do.
> I think we should drop the group here.

	Are you thinking that if e_leaf_clusters>cpg, we know it's
corrupted, but if it's just big enough to add up to greater than cpg, we
have no idea what happened?

Joel

-- 

	f/8 and be there.

Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127