[Ocfs2-tools-devel] [PATCH 1/3] o2cb.init: Disable online check during online

[Joel Becker]

On Thu, Feb 18, 2010 at 03:09:44PM -0800, Sunil Mushran wrote:
> Currently during online, the o2cb init script checks whether the cluster
> is already online and aborts if it is so. This patch removes that check and
> allows the init script to call o2cb_ctl to register newer nodes added to
> cluster.conf.

	This isn't quite right.  You're doing things that shouldn't be
re-done, like setting the stack name.  Also, if o2cb_ctl fails, the
failure path is to shut down the cluster.  Not something you want when
you were just trying to add some nodes.

Joel

-- 

"A narcissist is someone better looking than you are."  
         - Gore Vidal

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127