[Ocfs2-tools-devel] [PATCH 03/11] Ocfs2-tools: Add ocfs2_ioctl.h kernel header to ocfs2-tools.

[Joel Becker]

On Fri, Jan 08, 2010 at 04:50:53PM +0800, Tristan Ye wrote:
> +/* Codes for ocfs2_info_request */
> +
> +#define OCFS2_INFO_CLUSTERSIZE	(0x00000001)
> +#define OCFS2_INFO_BLOCKSIZE	(0x00000002)
> +#define OCFS2_INFO_SLOTNUM	(0x00000004)
> +#define OCFS2_INFO_LABEL	(0x00000008)
> +#define OCFS2_INFO_UUID		(0x00000010)
> +#define OCFS2_INFO_FS_FEATURES	(0x00000020)
> +#define OCFS2_INFO_FREEFRAG	(0x00000040)
> +#define OCFS2_INFO_FREEINODE	(0x00000080)

	The codes are never combined.  They do not need to be bits, they
can just be sequential numbers.  Make it an enum, starting at 1.

Joel

-- 

"I think it would be a good idea."  
        - Mahatma Ghandi, when asked what he thought of Western
          civilization

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127