[Ocfs2-tools-devel] [PATCH 1/2] o2cb_config: Add support for the heartbeat stanza

[Joel Becker]

On Thu, Dec 16, 2010 at 02:14:05PM -0800, Sunil Mushran wrote:
> @@ -159,6 +194,18 @@ static gint o2cb_config_fill_cluster(O2CBConfig *config, JConfig *cf,
>      if (!cluster)
>          goto out_error;
>  
> +    /* cluster: heartbeat_mode */
> +    rc = -ENOMEM;
> +    hb_mode = j_config_get_attribute(c_cfs, "heartbeat_mode");
> +    if (!hb_mode)
> +        hb_mode = g_strdup("local");

	If you've got a defined LOCAL_TAG for "local", I'd suggest you
use it in the two places you have instead hard-coded "local".
Otherwise, the patch looks good.

Joel

-- 

"I'm drifting and drifting
 Just like a ship out on the sea.
 Cause I ain't got nobody, baby,
 In this world to care for me."

Joel Becker
Senior Development Manager
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127