[Ocfs2-tools-devel] [PATCH 4/5] libo2cb: Extend libo2cb api to learn ip address/port/local of a registered node

[Sunil Mushran]

On 12/16/2010 07:12 PM, Joel Becker wrote:
> 	Didn't you just add tools_strchomp()?  I presume this is what
> you were referring to in the series description ;-)
>

yes

>> +	*ip_port = strtoul(val,&p, 0);
>> +	if (!p || (*p&&  *p != '\n'))
>> +		return O2CB_ET_INTERNAL_FAILURE;
> 	These are not internal failures, they are a problem with the
> values in configfs.  Probably more SERVICE_UNAVAILABLE.

ok