[Ocfs2-tools-devel] [PATCH 1/2] wireshark-ocfs2: Add dlm_query_region message support to dissector.

[jeff.liu]

Sunil Mushran wrote:
> On 12/10/2010 01:53 PM, Joel Becker wrote:
>> On Fri, Dec 10, 2010 at 08:08:22PM +0800, Jie Liu wrote:
>>> Example:
>>>
>>> Magic: Request (0xfa55)
>>> Len: 1092
>>> Type: Query Region (519)
>>> Sys Status: 0
>>> Status: 0
>>> Key: 0x666c6172
>>> Num: 0
>>> Payload1: 5C0220004342363337353033423141373436444542334436
>>> Payload2: 333635364531364641343142000000000000000000000000
>>> Payload3: 000000000000000000000000000000000000000037374439
>>> Payload4: 354546353143303134394432383233363734464343313632
>>> Payload5: 434638424443444132383435313737463444353941304632
>>> Payload6: 444344384445353037434333000000000000000000000000
>>> Node: 92
>>> Num Regions: 2
>>> Domain Namelen: 32
>>> Domain Name: CB637503B1A746DEB3D63656E16FA41B
>>> Regions:
>>> 77D95EF51C0149D2823674FCC162CF8BDCDA2845177F4D59A0F2DCD8DE507CC3
>>     If this is two regions, shouldn't there be a space between them?
> 
> Node: 92
> Num Regions: 2
> Domain Namelen: 32
> Domain Name: CB637503B1A746DEB3D63656E16FA41B
> Regions: 77D95EF51C0149D2823674FCC162CF8B DCDA2845177F4D59A0F2DCD8DE507CC3
> 
> Yes, we need a separator and a space should work.
> 
> BTW, how long can these lines be? We could have a max of 32 regions.
> 
Thanks both for your comments!
Since the maximum number of regions is 32, how about if we dump each region per line?

According to the "Num Regions", it should looks like:

Region1: 77D95EF51C0149D2823674FCC162CF8B
Region2: DCDA2845177F4D59A0F2DCD8DE507CC3
....
..
Region32:xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

-Jeff