[Ocfs2-tools-devel] [PATCH] Fix memleak which calculating number of extents

Goldwyn Rodrigues rgoldwyn at suse.de
Wed Aug 18 10:04:10 PDT 2010


While calculating extents calc_num_extents() does not free the buffers
allocated in the loop.

Found by Joel Becker while reviewing defrag.ocfs2

Signed-off-by: Goldwyn Rodrigues <rgoldwyn at suse.de>
--- 
diff --git a/debugfs.ocfs2/commands.c b/debugfs.ocfs2/commands.c
index 1f60049..ae12479 100644
--- a/debugfs.ocfs2/commands.c
+++ b/debugfs.ocfs2/commands.c
@@ -2092,6 +2092,7 @@ static errcode_t calc_num_extents(ocfs2_filesys *fs,
 			if (ret)
 				goto bail;
 
+			ocfs2_free(&buf);
 		}		
 
 		*ne = *ne + extents;



More information about the Ocfs2-tools-devel mailing list