[Ocfs2-tools-devel] [PATCH 21/30] fsck.ocfs2: verify dirent -> dx entry linkages

Tao Ma tao.ma at oracle.com
Thu Apr 29 16:48:17 PDT 2010


Joel Becker wrote:
> On Wed, Apr 28, 2010 at 06:26:26PM -0700, Mark Fasheh wrote:
>   
>> During pass2 we can trivially do a lookup on dirents while walking the
>> directory tree. This will help us make sure that an index entry exists for
>> each dirent. If an entry is not found, the users is prompted and the parent
>> directory will be marked for an index rebuild.
>>
>> Signed-off-by: Mark Fasheh <mfasheh at suse.com>
>> Cc: Joel Becker <joel.becker at oracle.com>
>> Cc: Sunil Mushran <sunil.mushran at oracle.com>
>> ---
>>  fsck.ocfs2/fsck.ocfs2.checks.8.in |    7 +++++++
>>  fsck.ocfs2/pass2.c                |   37 +++++++++++++++++++++++++++++++++++++
>>  2 files changed, 44 insertions(+), 0 deletions(-)
>>
>> diff --git a/fsck.ocfs2/fsck.ocfs2.checks.8.in b/fsck.ocfs2/fsck.ocfs2.checks.8.in
>> index 5cda023..cfbb12e 100644
>> --- a/fsck.ocfs2/fsck.ocfs2.checks.8.in
>> +++ b/fsck.ocfs2/fsck.ocfs2.checks.8.in
>> @@ -1061,6 +1061,13 @@ file system.
>>  
>>  Answering yes will truncate the invalid index.
>>  
>> +.SS "DX_LOOKUP_FAILED"
>> +A directory entry is missing an entry in the directory index. Not
>> +found in directory index. The missing index entry will cause lookups
>> +on this name to fail.
>>     
>
> 	This doesn't quite read right.  I think the middle sentence is
> extraneous.  Do you mean:
>
> A directory entry is missing an entry in the directory index.  The
> missing index entry will cause lookups on this name to fail.
>   
hey, that is reason why I can't sob these patches.
I think I am not qualified to sob any patch that includes manpage or 
fsck/tunefs prompt change. ;)

Regards,
Tao



More information about the Ocfs2-tools-devel mailing list