[Ocfs2-tools-devel] [PATCH 18/30] mkfs.ocfs2: create root and orphan directories as indexed

[Joel Becker]

On Wed, Apr 28, 2010 at 06:26:23PM -0700, Mark Fasheh wrote:
> +	for (i = 0; i < num_slots; i++) {
> +		ret = ocfs2_lookup_system_inode(fs, ORPHAN_DIR_SYSTEM_INODE,
> +						i, &orphan_dir_blkno);
> +		if (ret) {
> +			com_err(s->progname, ret,
> +				"while looking up orphan dir %d for indexing",
> +				i);
> +			goto bail;
> +		}
> +
> +		ret = ocfs2_dx_dir_build(fs, orphan_dir_blkno);
> +		if (ret) {
> +			com_err(s->progname, ret, "while indexing root directory");
> +			goto bail;
> +		}

	I'd be sorely tempted to change from "index every orphan dir" to
"index every system file that is S_ISDIR", just because it is future
proof.  That said, we can change to testing S_IFDIR when we have another
system file that's a directory.

Sob.

Joel

-- 

"Practice random acts of kindness and senseless acts of beauty."

 Oh, and don't forget where your towel is.

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127