[Ocfs2-tools-devel] [PATCH 16/30] tunefs.ocfs2: move o2ne_add_tailers() into libocfs2ne.c

[Joel Becker]

On Wed, Apr 28, 2010 at 06:26:21PM -0700, Mark Fasheh wrote:
>   * Starting, opening, closing, and exiting.
> diff --git a/tunefs.ocfs2/libocfs2ne.h b/tunefs.ocfs2/libocfs2ne.h
> index 18380be..250ba76 100644
> --- a/tunefs.ocfs2/libocfs2ne.h
> +++ b/tunefs.ocfs2/libocfs2ne.h
> @@ -300,11 +300,50 @@ struct tunefs_trailer_context {
>  					   iteration of the directory */
>  };
>  
> +/* A dirblock we have to add a trailer to */
> +struct tunefs_trailer_dirblock {

	This structure doesn't need to be in the header, it is private
to the tunefs_trailer_context.  The definition should be in
libocfs2ne.c.

Joel

-- 

Life's Little Instruction Book #198

	"Feed a stranger's expired parking meter."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127