[Ocfs2-tools-devel] [PATCH 24/30] dx_dirs: remove unncessary return value assignment

Mark Fasheh mfasheh at suse.com
Wed Apr 28 18:26:29 PDT 2010


From: Coly Li <coly.li at suse.de>

This patch removes unnecessary return value assigned in
ocfs2_dx_entries_iterate() and ocfs2_dx_frees_iterate().

Thanks for Tao Ma for catching this.

Signed-off-by: Coly Li <coly.li at suse.de>
Cc: Mark Fasheh <mfasheh at suse.com>
Signed-off-by: Tao Ma <tao.ma at oracle.com>
---
 libocfs2/dir_iterate.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/libocfs2/dir_iterate.c b/libocfs2/dir_iterate.c
index b23ee12..add3445 100644
--- a/libocfs2/dir_iterate.c
+++ b/libocfs2/dir_iterate.c
@@ -379,7 +379,6 @@ extern errcode_t ocfs2_dx_entries_iterate(ocfs2_filesys *fs,
 	struct dx_iterator_data data;
 
 	if (!S_ISDIR(dir->i_mode) && !ocfs2_dir_indexed(dir)) {
-		ret = 0;
 		goto out;
 	}
 
@@ -449,12 +448,10 @@ extern errcode_t ocfs2_dx_frees_iterate(ocfs2_filesys *fs,
 	struct ocfs2_dir_block_trailer *trailer;
 
 	if (!S_ISDIR(dir->i_mode) || !(ocfs2_dir_indexed(dir))) {
-		ret = 0;
 		goto out;
 	}
 
 	if (dx_root->dr_flags & OCFS2_DX_FLAG_INLINE) {
-		ret = 0;
 		goto out;
 	}
 
-- 
1.6.4.2




More information about the Ocfs2-tools-devel mailing list